Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove prebuilt cache #18

Merged
merged 1 commit into from
Apr 17, 2022
Merged

remove prebuilt cache #18

merged 1 commit into from
Apr 17, 2022

Conversation

Artturin
Copy link
Member

it increases the closure size and limits the system we support
in the future we can implement this better in the script

it increases the closure size and limits the system we support
in the future we can implement this better in the script
@DavHau
Copy link
Member

DavHau commented Apr 16, 2022

I think the builtin index DB is quite useful and increases the UX of comma a lot as users can just install and use the tool without extra steps that involve learning about the nix-index tool etc.

We could just allow the builtin index to be null and set it null whenever it's not available for a system.

@Artturin
Copy link
Member Author

Artturin commented Apr 16, 2022

The builtin index should be handled outside of nix in the script because it is quite large

Then we could update it too

@DavHau
Copy link
Member

DavHau commented Apr 17, 2022

The builtin index should be handled outside of nix in the script because it is quite large

Sounds like a good idea. I think this should be implemented by the current PR. Then we won't lose that feature.

@Artturin Artturin merged commit 10ba38d into master Apr 17, 2022
@Artturin Artturin deleted the remove-prebuilt branch April 17, 2022 13:28
@Artturin
Copy link
Member Author

Artturin commented Apr 17, 2022

i merged this now so the users who couldn't install comma now can install it

i'll start working on implementing it in the script now

@Artturin
Copy link
Member Author

actually, that feature should be implemented in nix-index itself

@DavHau
Copy link
Member

DavHau commented May 19, 2022

actually, that feature should be implemented in nix-index itself

I'm not sure if I would agree. But if you think so, you should be the one who makes sure that this feature is implemented in nix-index before you remove that feature here. Next time it would be nice if you would check what others think about it, before deciding about such change.

Why do I think this feature is important?
One power comma gives you is to just use the tools you're used to on another machine which doesn't have your environment.
Earlier you could just do a nix shell nixpkgs#comma and have a fully featured comma quickly.

This capability is now broken through that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants