Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: programs.rbw broken #2476

Closed
1 task done
srhb opened this issue Nov 15, 2021 · 7 comments
Closed
1 task done

bug: programs.rbw broken #2476

srhb opened this issue Nov 15, 2021 · 7 comments
Assignees
Labels

Comments

@srhb
Copy link

srhb commented Nov 15, 2021

Is there an existing issue for this?

  • I have searched the existing issues

Issue description

rbw has begun trying to mutate its own config file during normal use. This obviously breaks.

rbw get: failed to save config to /home/sarah/.config/rbw/config.json: Read-only file system (os error 30)

Maintainer CC

@ambroisie

System information

❯ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 5.10.79, NixOS, 21.11 (Porcupine)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.5pre20211007_844dd90`
 - channels(root): `""`
 - channels(sarah): `""`
 - nixpkgs: `/home/sarah/src/nixpkgs`
@srhb srhb added bug triage Issues or feature request that have not been triaged yet labels Nov 15, 2021
@rycee
Copy link
Member

rycee commented Nov 15, 2021

That's kind of a bummer. We don't really have a good response to such program behavior in HM. I guess we could make the module install the file using an activation block but that's kind of ugly and would only apply during activation. I hope this can be fixed upstream instead 🙂

@srhb
Copy link
Author

srhb commented Nov 16, 2021

Agreed! Just tracking here, hope that's okay. :) I'm sure we can work something out with upstream.

@akho
Copy link
Contributor

akho commented Nov 18, 2021

For now, setting device_id works and prevents rbw from misbehaving

  programs.rbw.settings.device_id = "<put uuid here>";

Not a good long-term solution at all, though.

@ivankovnatsky
Copy link
Contributor

ivankovnatsky commented Dec 14, 2021

This is related to this:

Agreed! Just tracking here, hope that's okay. :) I'm sure we can work something out with upstream.

so the upstream here being probably bitwarden not rbw.

While device_id is obviously will be different for a different machine this makes a bit harder to keep a declarative configuration of rbw. I myself configuring that out of HM for now.

@berbiche berbiche removed the triage Issues or feature request that have not been triaged yet label Jan 20, 2022
@berbiche
Copy link
Member

Should we mark the module as broken somehow?
If "settings is a set and it does not contain a device_id" then we print a warning?

@ivankovnatsky
Copy link
Contributor

ivankovnatsky commented Feb 15, 2022

Nah, it should be fixed in 1.4.2: doy/rbw@42badc1.

nixpkgs@master already got 1.4.3.

Running fine on my side on 1.4.3 overlay. Device ID file placed here: .local/share/rbw/device_id

@berbiche
Copy link
Member

Alright, this can be marked as resolved then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants