Back out "Don't run preSwitchChecks during install" #475
Conversation
This backs out commit be2d9d7.
|
In the original PR adding the pre-switch checks, it explicitly mentions they are meant to run during installation (prior to the installation of the bootloader) NixOS/nixpkgs#236375 |
There was a problem hiding this comment.
The specific srvos check you are linking to was fixed before #447 was merged here.
As written there: we don't switch from one system to another during install, because in the case where it's an empty disk, there's just no system to speak of before the switch.
And if you use it because the original system is too broken to do a nixos-rebuild inside, preSwitchChecks most probably won't neither pass nor help.
So I'd like to see a more practical argument than just a mental model (which isn't entirely correct imo) before a possible revert?
I mean, I don't care too much either way, I just think it's much more practical this way, but we could always make it optional if needed.
The PR description says
Which I parse as "during switch to new system, but before bootloader is installed". It does not say anything explicitly about the installation of new systems. |
|
@Mic92 was there a specific issue you ran into recently that made you merge #447 recently? I think that we should match upstream rather than adding an extra flag to diverge our behaviour. In my opinion, pre-switch checks should be able to handle when there's no system/state yet. From
|
|
I had no particular issue. It was more about the fact that many probably don't test installation very often for their preSwitch checks. |
This backs out commit be2d9d7.
This backs out of #447
Now that nix-community/srvos#591 (comment) is fixed upstream, I think it would be preferable to run the pre-switch checks before installing to match the default behaviour of
nixos-installand I usually think ofnixos-installasnixos-rebuild switchwith a few extra steps like installing a bootloader.