Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix StatusMessage serialization and deserialization #67

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix StatusMessage serialization and deserialization #67

wants to merge 2 commits into from

Conversation

hgzimmerman
Copy link

fixes #66

@hgzimmerman
Serialize StatusMessage (#14)
3e4269b
@hgzimmerman
Deserialize StatusMessage tag as content not attribute (#15)
5ac2281 
* Deserialize StatusMessage tag as content not attribute

* make pub
njaremko
njaremko reviewed Jan 28, 2025
View reviewed changes
Copy link
Owner

@njaremko njaremko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised this took so long to be brought up. Good catch.

You're right that this is a breaking change. Instead of changing the struct in a breaking way, you can change "@Value" to "$text", and I believe that'll work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njaremko njaremko njaremko left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

StatusMessage serialization issues
2 participants
@hgzimmerman @njaremko