Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instructions for generating the drift file #7

Open
andrescarmona opened this issue May 5, 2021 · 4 comments
Open

instructions for generating the drift file #7

andrescarmona opened this issue May 5, 2021 · 4 comments
Assignees
Labels
documentation Improvements or additions to documentation Drift / FP Drift and FP issues / questions

Comments

@andrescarmona
Copy link
Collaborator

Hello, I miss in the README the instructions for generating the drift file

cheers,

Andres

@njcuk9999 njcuk9999 added the documentation Improvements or additions to documentation label May 5, 2021
@njcuk9999
Copy link
Owner

You are correct it isn't in there - it probably should be.

Maybe @eartigau can correct me but I think the only changes are:

  1. Copy o_pp_e2dsff_C.fits files into the science directory (in an FP) directory for odometers that have a FP in their C fiber
  2. Copy a_pp_e2dsff_C.fits files (FP_FP) into the science directory (in an FP)
  3. Copy the FP_pos.fits file into the masks directory
  4. Copy the Template_s1d_FP_sc1d_v_file_AB.fits into the templates directory
  5. in the config.yaml
    • OBJECT_SCIENCE: FP
    • OBJECT_TEMPLATE: FP
    • INPUT_FILE: *e2dsff*C.fits

The FP_pos.fits file and Template_s1d_FP_sc1d_v_file_AB.fits file don't come from APERO so @eartigau will have to tell you how to make these or give you them I guess?

@eartigau can you also check my config.yaml parameters above

@njcuk9999 njcuk9999 added the Drift / FP Drift and FP issues / questions label May 5, 2021
@andrescarmona
Copy link
Collaborator Author

Thanks Neil, we have the blaze AB, should we use the blaze_C ?

@andrescarmona
Copy link
Collaborator Author

I have from the previous release the FP_pos.fits file and Template_s1d_FP_sc1d_v_file_AB.fits. I was wondering whether we have a Template_s1d_FP_sc1d_v_file_C.fits ?

@njcuk9999
Copy link
Owner

So I think this was just Etienne being lazy - Template_s1d_FP_sc1d_v_file_AB.fits is actually Template_s1d_FP_sc1d_v_file_C.fits i.e. it is made of s1d FP from the C fibers (as far as I am aware) and not from the AB s1d (as there are far far fewer of these).

The reason it has this name is probably just that the "default" mask is defined as:
"Template_s1d_{OBJECT_TEMPLATE}_v_file_AB.fits`
and from your config you set:

# Set template object name
OBJECT_TEMPLATE: FP

therefore it "needs" the _AB.fits part - you could rename this FP template file and in the config file set:

# Set template file (None for default)
TEMPLATE_FILE: Template_s1d_FP_sc1d_v_file_C.fits

and the result would be the same.

@eartigau correct me if I am wrong about the s1d template coming from the C files not the AB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Drift / FP Drift and FP issues / questions
Projects
None yet
Development

No branches or pull requests

3 participants