Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generation of stubs #60

Closed
trym-b opened this issue Jul 10, 2023 · 1 comment
Closed

Generation of stubs #60

trym-b opened this issue Jul 10, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@trym-b
Copy link
Contributor

trym-b commented Jul 10, 2023

Commit 9567159 disabled the automatic commit of generated protobuf stubs. This is not the best for the long-term, so a solution to get the stubs generated is required.

Some of the alternatives are:

  • Automatically create PRs to the default branch whenever relevant files are updated
  • Re-enable the auto-commit system from 9567159
  • Make the CI fail if the feature branch's newly generated stubs do not match the default branch's.
  • Something else
@trym-b trym-b added the enhancement New feature or request label Jul 10, 2023
@trym-b
Copy link
Contributor Author

trym-b commented Jul 14, 2023 •
edited
Loading

Which commit solves this issue again? 324f1ab ?
Or are both commits in the pull request #62 ?

This way we can more easily find the relevant work in the future if we need to :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@trym-b