Class Composition of json members produces incorrect json when constructing with initialization list

[killerswin2]

Description

When using Composition of types in a class for json abstraction, constructing the class produces wrong incorrect json when using an initialization list. Passed json objects/docs seem to be pushed back in the json object attribute attached to the class.

Reproduction steps

just call the class constructor of your class and pass in the json object.

Expected vs. actual results

[[10,20,30,40,{"apple":20}]] with initialization list construction.

[10,20,30,40,{"apple":20}] without, manually assign the member attribute to be

Minimal code example

#include <iostream>
#include <string>
#include <nlohmann/json.hpp>


class game_data_json_array
{
public:
	game_data_json_array(nlohmann::json object) : jsonArray{ object } {}		// produces [[10,20,30,40,{"apple":20}]]
	nlohmann::json jsonArray;
};


class game_data_json_array2
{
public:
	game_data_json_array2(nlohmann::json object) {
		jsonArray = object; 				// produces [10,20,30,40,{"apple":20}]
	}
	nlohmann::json jsonArray;
};


// json 
/*
[
  10,
  20,
  30,
  40,
  {"apple": 20}
]

*/


int main(void)
{
	nlohmann::json jsonArray = nlohmann::json::parse(R"([
  10,
  20,
  30,
  40,
  {"apple": 20}
])");
	game_data_json_array test1 = game_data_json_array(jsonArray);
	game_data_json_array2 test2 = game_data_json_array2(jsonArray);

	std::cout << test1.jsonArray;

	std::cout << "\n";

	std::cout << test2.jsonArray;

	return 0;
}

Error messages

N/A

Compiler and operating system

Windows 10, msvc 1935

Library version

3.11.2

Validation

• The bug also occurs if the latest version from the develop branch is used.
• I can successfully compile and run the unit tests.

[gregmarr]

See if this first FAQ entry answers your question: https://json.nlohmann.me/home/faq/

[killerswin2]

oof, that's what I get for not reading the faq