Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use maxele.gr3 for maximum elevation results #124

Open
SorooshMani-NOAA opened this issue Dec 12, 2023 · 1 comment
Open

Use maxele.gr3 for maximum elevation results #124

SorooshMani-NOAA opened this issue Dec 12, 2023 · 1 comment
Assignees

Comments

@SorooshMani-NOAA
Copy link
Collaborator

Currently the out_2d*.nc file is used to get the max-elevation dataset for analysis:

class MaximumElevationOutput(MaximumScalarFieldOutputCalculator):
"""
``out2d.nc`` - Derived Maximum Elevation at All Nodes in the Model Grid
"""
out_filename = 'schism_max_elevation.nc'
file_patterns = ['out2d_*.nc']

I think the main reason behind that is the missing maximum elevation time in the gr3 file. Since the timing data is not currently being used, maybe it makes more sense to just use the maxelev.gr3 values instead. out2d_* is output is controlled by output step, while maxelev.gr3 is the actual maximum.

Just FYI @FariborzDaneshvar-NOAA

@SorooshMani-NOAA SorooshMani-NOAA self-assigned this Dec 12, 2023
@FariborzDaneshvar-NOAA
Copy link
Collaborator

@SorooshMani-NOAA thanks for looking into this. Based on my experience working with outliers of with/out NWM, elevations from maxelev.gr3 could be much higher than out2d_*.nc, and the reason is that the first one includes the entire time period and might include noises from the earlier times! Here is one example: https://github.com/noaa-ocs-modeling/SurgeTeamCoordination/issues/115#issuecomment-1740210537

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants