Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we really need to provide an argument for -s option? #77

Closed
c02y opened this issue Sep 9, 2020 · 3 comments
Closed

Do we really need to provide an argument for -s option? #77

c02y opened this issue Sep 9, 2020 · 3 comments

Comments

@c02y
Copy link

c02y commented Sep 9, 2020

When I try to run tdrop -ma -w 100% -h 95% -y "$PANEL_HEIGHT" -s kitty, it fails and says:

Error: Program to run is required as a positional argument. For help use -h or --help or see the manpage.

So in the tdrop script, -s need an option for session_name, but what if I don't want a session name manually, normally I just use tmux, I got my own ~/.tmux.conf and set status-left as #S, the #S is the session-name, I never provide a session name manually, so by default, this value will be an increasing number start from 0.

So I suggest the argument for -s should be optional, if no argument provided, use the tmux default, it provided, use the provided one.

UPDATE:
Actually I personally don't need -s option, I start a script call t which is a wrapper for tmux in kitty.conf, so this is actually what I need.

But the original suggestion still needs to be done.

@c02y c02y changed the title Do we really need to provide a argument for -s option? Do we really need to provide an argument for -s option? Sep 9, 2020
@noctuid
Copy link
Owner

noctuid commented Sep 13, 2020

If you want to do this, you can just run whatever command you want to in the terminal instead of using -s (e.g. tdrop kitty tmux).

@noctuid noctuid closed this as completed Sep 13, 2020
@c02y
Copy link
Author

c02y commented Sep 14, 2020

Yes, I got it now. After searching other people's usage in the whole github, I managed to make my needs work.

But I think it is better to provide something like a wiki page for some examples of regular programs.

There are a lot of class for those programs in tdrop shell script. I have to anaylyze the file carefully to know how to make those programs work. For example it took me a while to make emacsclient work with tdrop.

@c02y
Copy link
Author

c02y commented Sep 15, 2020

Wait... you mean tdrop kitty tmux, the line in my page got wrapped after the word kitty, I didn't notice the word tmux at the end.

I tried tdrop kitty tmux in terminal manually, it starts kitty with empty content, without even a shell prompt, and I cannot do typing in it.

Actually I managed to use tdrop + kitty using tdrop -ma -w 100% -h 90% kitty, and I use a shell script which is a wrapper of tmux as the shell command in kitty.conf, I usually use this shell script as the start command in other terminals such as xfce4-terminal or yakuake.

@noctuid noctuid added this to the 0.5.0 milestone Apr 27, 2022
@noctuid noctuid closed this as completed in 797cc36 May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants