-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google SAML #167
Comments
+1 |
Yes. It does.
And (in app.js):
I've used Let me know if you need a hand. |
@abelosorio Have you tried fetching user groups as part of the SAML response from google? I was able to add custom field to users which can be added in 'Attribute Mapping' section, but I could not find a way to fetch the groups the user belongs to (member-of)! |
Hi @aby040! No, I haven't done that. Sadly I'm not longer part of the project where I used Google SAML. Sorry man, I cannot help this time :( |
How to extract the user profile from the samlstrategy callback.. we want to show the logged in user's name, email,..etc.. Any idea? |
Does failureRedirect get handled by the idp? With google if the user is only logged in with their personal account, we get a dead end 403 error page, our redirect is ignored. I know there is a passport-saml fork that handles this well with a |
Do you know which fork? It would be nice to have that fork contribute back to this project if at all possible. |
@cjbarth it's old https://github.com/DmtrPn/passport-saml He took a tailor-made brute force approach to the problem... It would be more helpful to have a more general solution that might be useful even outside of Google... Like Microsoft, and foreign niche IDPs like GMX, Line etc or other edge cases, perhaps automated testing or staging and contractor accounts. |
I'm not sure what problems Google, Instagram, Twitter or others are facing using |
If you are using Google for identity, I would suggest using Google's OAuth option if possible. SAML continues to have security issues related to XML parsing. OAuth uses JSON and seems fewer security issues. I realize some service providers only support SAML, which is too bad. |
For completeness, OAuth has its own set of issues; never treat security as a slam-dunk, bolt-on, or drop-in. When it comes to XML parsing issues, it is very hard to exploit because that would mean that a private key of the IdP was leaked or you aren't using signing. If the key is leaked, then you have bigger problems, if you aren't signing, turn it on. |
@cjbarth fair points. My bias against XML colors my perspective. |
Does passport-saml support Google SAML?
The text was updated successfully, but these errors were encountered: