Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unmaintained should.js #653

Closed
cjbarth opened this issue Oct 1, 2021 · 2 comments · Fixed by #687
Closed

Remove unmaintained should.js #653

cjbarth opened this issue Oct 1, 2021 · 2 comments · Fixed by #687
Labels
dependencies Pull requests that update a dependency file pr-welcome

Comments

@cjbarth
Copy link
Collaborator

cjbarth commented Oct 1, 2021

should.js is unmaintained. It should be removed from passport-saml.
@cjbarth cjbarth added pr-welcome dependencies Pull requests that update a dependency file labels Oct 1, 2021
@kg0r0
Copy link
Contributor

kg0r0 commented Feb 20, 2022

Is there any problem with the same revision policy as the following PR?
node-saml/node-saml#41

@cjbarth
Copy link
Collaborator Author

cjbarth commented Apr 4, 2022

It would be nice if both projects used the same library, so I'm good with Chai with passport-saml too.

@kg0r0 kg0r0 mentioned this issue Apr 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file pr-welcome
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate from "should" to "chai" kg0r0/passport-saml
2 participants
@cjbarth @kg0r0