From 7825535931d1eac9ed25a01b9f2290415f579507 Mon Sep 17 00:00:00 2001 From: Oleksandr Date: Mon, 20 May 2019 17:30:36 -0700 Subject: [PATCH 1/2] Added a conditional statement to set NameIDFormat Added a conditional statement to set NameIDFormat only if identifierFormat is specified in options. This should prevent an error in AD FS when identifierFormat set to null: https://github.com/bergie/passport-saml/issues/338 --- lib/passport-saml/saml.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/passport-saml/saml.js b/lib/passport-saml/saml.js index 7873023a..73440af9 100644 --- a/lib/passport-saml/saml.js +++ b/lib/passport-saml/saml.js @@ -1249,7 +1249,10 @@ SAML.prototype.generateServiceProviderMetadata = function( decryptionCert, signi }; } - metadata.EntityDescriptor.SPSSODescriptor.NameIDFormat = this.options.identifierFormat; + if (this.options.indentifierFormat) { + metadata.EntityDescriptor.SPSSODescriptor.NameIDFormat = this.options.identifierFormat; + } + metadata.EntityDescriptor.SPSSODescriptor.AssertionConsumerService = { '@index': '1', '@isDefault': 'true', From 98fed92ea5381c7850522b76dd2896c4bab584c9 Mon Sep 17 00:00:00 2001 From: Oleksandr Havrylyuk Date: Tue, 21 May 2019 08:59:37 -0700 Subject: [PATCH 2/2] Fixed misspelling --- lib/passport-saml/saml.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/passport-saml/saml.js b/lib/passport-saml/saml.js index 73440af9..9e5c4e5e 100644 --- a/lib/passport-saml/saml.js +++ b/lib/passport-saml/saml.js @@ -1249,10 +1249,10 @@ SAML.prototype.generateServiceProviderMetadata = function( decryptionCert, signi }; } - if (this.options.indentifierFormat) { + if (this.options.identifierFormat) { metadata.EntityDescriptor.SPSSODescriptor.NameIDFormat = this.options.identifierFormat; } - + metadata.EntityDescriptor.SPSSODescriptor.AssertionConsumerService = { '@index': '1', '@isDefault': 'true',