Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PUT / POST requests broken in node 0.12.0 #777

Open
billmccord opened this issue Feb 19, 2015 · 5 comments
Open

PUT / POST requests broken in node 0.12.0 #777

billmccord opened this issue Feb 19, 2015 · 5 comments

Comments

@billmccord
Copy link

When I upgraded to node v0.12.0, performing proxied PUT / POST requests gave errors like this:
node_modules/http-proxy/lib/http-proxy/index.js:119
throw err;
^
Error: write after end
at ClientRequest.OutgoingMessage.write (_http_outgoing.js:413:15)
at IncomingMessage.ondata (_stream_readable.js:540:20)
at IncomingMessage.emit (events.js:107:17)
at /Users/bill/Source/LN/impactscore_client/node_modules/connect-restreamer/index.js:15:13
at process._tickCallback (node.js:355:11)

Rolling back to node v0.10.36, everything is working fine.

@diimdeep
Copy link

Same here, from atom-shell, i think same node version

Uncaught Exception:
Error: write after end
    at ServerResponse.OutgoingMessage.write (_http_outgoing.js:415:15)
    at Socket.proxyError (/Users/wolf/hello-atom/node_modules/ipython-notebook-proxy/node_modules/http-proxy/lib/node-http-proxy/http-proxy.js:204:13)
    at Socket.g (events.js:202:16)
    at Socket.emit (events.js:138:20)
    at net.js:452:14
    at process._tickDomainCallback (node.js:392:11)

@shlomihassan
Copy link

hi guys,

i having the same problem
have you managed to solve the problem ?

@jcrugzz
Copy link
Contributor

jcrugzz commented Apr 14, 2015

I'd love to have a failing test case added in tests so we can get this resolved.

@leejefon
Copy link

leejefon commented Jul 9, 2015

I had the same problem with connect-restreamer. I found a fix ([https://github.com/dominictarr/connect-restreamer/issues/8]). Not the best solution, but it works for me :)

@trustmaster
Copy link

I came across the same error message in code not using node-http-proxy. Not sure if this helps you guys, but what caused this bug in my case was http.get being used instead of http.request for POST requests. Seems like it was an alias in Node 0.10 but the behavior changed in 0.12. Replacing http.get with http.request fixed it for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants