Use git config core.autocrlf false on windows machines

[joyeecheung]

Refs: nodejs/node#19221

I think the current git setting on those machines converts CRLF to LF on checkout, which should not be what normal windows devs are using because the JS linter would complain about all the CRLF in the code base, and this causes the Windows CI of nodejs/node#19221 to fail because it is matching output mixed with code from local files.

Can somebody help me configure this on the CI? git config core.autocrlf false should stop git from converting the line feeds. I don't think I have access to the windows jobs. Thanks!

[bzoz]

vcbuild lint-js works fine with both core.autocrlf set to true and false. The GitHub documentation suggests setting it to true, so I would guess most Windows devs would have it this way (at least I do).

[joyeecheung]

@bzoz Hmm, in that case we should set git config core.autocrlf true on the CI? I am not sure about the current settings (input?), but it is converting LF to CRLF on check out so the tests in nodejs/node#19221 fails on the CI.

[joyeecheung]

@MSLaguana suggested in nodejs/node#19221 (comment) to update .gitattributes instead, I'll try that route for the time being

[joaocgreis]

There has been plenty of discussion around this in the past. In Windows, LF should work as much as possible but CRLF is the right line ending. Thus, we should always make sure that Node compiles and works with CRLF. Git is installed with with core.autocrlf=true, which is the default setting so I believe it's how most developers have it.

I've once made my own attempt at .gitattributes, nodejs/node#7019 (actually started much simpler than the final version there now), but there was no consensus so nodejs/node#8785 landed instead.

autocrlf should stay true in CI machines. @joyeecheung I'll try to take a better look at your PR in node.

[maclover7]

@joyeecheung @BridgeAR is this still needed?

[joyeecheung]

@maclover7 The particular issue should be fixed by nodejs/node#20754 I think it's fine to keep core.autocrlf=true if we want to test the default git config on Windows as @joaocgreis suggested.