Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessing to aix61-ppc64 for investigate missing gas or llvm version detection #1569

Closed
shigeki opened this issue Nov 13, 2018 · 11 comments
Closed

Comments

@shigeki
Copy link

shigeki commented Nov 13, 2018

This issue was found during working WIP patch upgrading OpenSSL-1.1.1 as referenced in nodejs/node#18770. .
In aix64-ppc64, the detection of asm compiler version has an issue for https://ci.nodejs.org/job/node-test-commit-aix/18812/nodes=aix61-ppc64/consoleFull as shows.

22:53:36 WARNING: Could not recognize `gas`: 
..
22:53:36                  'gas_version': '0',
22:53:36                  'llvm_version': 0,

It seems gas or llvm version detection has some issues.
I'd like to have an access to login the server in order to debug the issue?

@richardlau
Copy link
Member

This come up during the 1.1.0 update. It looked like AIX was running the native assembler and not gas: nodejs/node#19944 (comment)

@shigeki
Copy link
Author

shigeki commented Nov 13, 2018

@richardlau Wow, I forgot the the issue in a half year ago. AIX also has own assembler. Thanks for reminding me of it.

I need to know if it does not have an option of --noexecstack as https://ci.nodejs.org/job/node-test-commit-aix/18797/nodes=aix61-ppc64/console show the error.
If so, I have to add an exception rule of cflag not to add the option in aix.

04:34:07 Assembler:
04:34:07 line 1: 1252-168 --noexecstack is not a recognized flag.
04:34:07 line 1: 1252-170 Usage: as [-a{32|64}] -l[ListFile] -s[ListFile] -n Name
04:34:07 			-o ObjectFile [-w|-W] -x[XCrossFile] -u
04:34:07 			-m ModeName [-i] [-p{off|on}] [-E{off|on}] [-v] [InputFile]
04:34:07 gmake[2]: *** [/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/out/Release/obj.target/openssl/deps/openssl/openssl/ssl/bio_ssl.o] Error 1
04:34:07 gmake[2]: *** Waiting for unfinished jobs....

@shigeki
Copy link
Author

shigeki commented Nov 13, 2018

I've also missed to know that AIX is based on PPC not Intel.
The support of AVX2 in shigeki/node@7f103fd is no longer needed. I would like to check the bare openssl-1.1.1 build binaries on aix if they are the same ones built in Node.

@refack
Copy link
Contributor

refack commented Nov 13, 2018

@nodejs/build @nodejs/platform-aix
I would like another +1 before proceeding.

@Trott
Copy link
Member

Trott commented Nov 13, 2018

+1 from me.

@refack
Copy link
Contributor

refack commented Nov 13, 2018

Keys in as [email protected]

@refack refack self-assigned this Nov 13, 2018
@gdams
Copy link
Member

gdams commented Nov 13, 2018

+1

1 similar comment
@mhdawson
Copy link
Member

+1

@shigeki
Copy link
Author

shigeki commented Nov 14, 2018

@refack Thanks. I can login the host and confirmed the assembler version token. I'm going to fix gyp scripts tomorrow.

# gcc -Wa,-v -c -o /dev/null -x assembler /dev/null
as V6.1

@shigeki
Copy link
Author

shigeki commented Nov 16, 2018

The issue was resolved by shigeki/node@dea84b0.

@refack Please remove my access to 140.211.9.101. I removed /home/shigeki. Thanks.

@refack
Copy link
Contributor

refack commented Nov 16, 2018

Done.
Thanks for the ping.

@refack refack closed this as completed Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants