Node.js 15 failures

[BethGriggs]

• Node Version: v15.0.0
• CitGM Version: v7.1.9

All platforms:

• citgm.@hapi/shot-v5.0.4 - lib: add new globals from Node.js 15.x hapijs/lab#997
• citgm.resolve-v1.17.0 - needs update for new core modules
• citgm.serialport-v9.0.2 - npm 7, should be fixed by deps: upgrade eslint to 7 serialport/node-serialport#2153
• citgm.tape-v5.0.1 - fixed by 1ac9ecf927bb1958857cb4050ec725cd3f22d27a to handle stack changes.
• citgm.ws-v7.3.1 - ws issue is fixed in [email protected]
• citgm.yargs-v16.1.0 - npm 7, fix in progress

macOS:

• osx10.14 and osx10.15 have a bunch of additional failures, but they do seem familiar.
  • https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2523/nodes=osx1014/testReport

[ljharb]

What are the failures with tape? Which core modules is resolve failing to detect?

[BethGriggs]

[email protected] from https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2523/nodes=ubuntu1804-64/testReport/(root)/citgm/tape_v5_0_1/:

        not ok 3 - should be equivalent
           ---
           found: |
             $TEST/async-await/sync-error.js:7
                 throw new Error('oopsie');
                 ^
             Error: oopsie
                 at Test.myTest ($TEST/async-await/sync-error.js:$LINE:$COL)
                 at Test.bound [as _cb] ($TAPE/lib/test.js:$LINE:$COL)
                 at Test.run ($TAPE/lib/test.js:$LINE:$COL)
                 at Test.bound [as run] ($TAPE/lib/test.js:$LINE:$COL)
                 at processImmediate (node:internal/timers:$LINE:$COL)
           wanted: |
             $TEST/async-await/sync-error.js:7
                 throw new Error('oopsie');
                 ^
             Error: oopsie
                 at Test.myTest ($TEST/async-await/sync-error.js:$LINE:$COL)
                 at Test.bound [as _cb] ($TAPE/lib/test.js:$LINE:$COL)
                 at Test.run ($TAPE/lib/test.js:$LINE:$COL)
                 at Test.bound [as run] ($TAPE/lib/test.js:$LINE:$COL)
           at:
             line: 189
             column: 11
             file: test/async-await.js
           stack: |
             test/async-await.js:189:11
             ChildProcess.<anonymous> (test/common.js:90:9)
             ChildProcess.emit (node:events:327:20)
             Process.ChildProcess._handle.onexit (node:internal/child_process:277:12)
           source: |
             t.same(stripFullStack(stderr), [
           ...
         1..3
         # failed 1 of 3 tests
     not ok 6 - sync-error # time=119.536ms
       ---
       at:
         line: 170
         column: 5
         file: test/async-await.js
       results:
         plan:
           start: 1
           end: 3
         count: 3
         pass: 2
         ok: false
         fail: 1
         time: 119.536
       source: |
         tap.test('sync-error', function (t) {
       ...
     # Subtest: async-error
         ok 1 - should be equivalent
         ok 2 - should be equivalent
         ok 3 - should be equivalent
         1..3
     ok 7 - async-error # time=125.421ms
     1..7
     # failed 1 of 7 tests
     # time=998.3ms
 not ok 4 - test/async-await.js # time=1120.491ms
   ---
   timeout: 30000
   file: test/async-await.js
   results:
     ok: false
     count: 7
     pass: 6
     fail: 1
     plan:
       start: 1
       end: 7
   exitCode: 1
   command: /home/iojs/build/workspace/citgm-smoker/nodes/ubuntu1804-64/smoker/bin/node
   arguments:
     - test/async-await.js
   ...

[email protected] from https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2523/nodes=ubuntu1804-64/testReport/(root)/citgm/resolve_v1_17_0/

not ok 190 assert/strict is a core module
...
not ok 210 dns/promises is a core module
...
not ok 250 stream/promises is a core module
...
not ok 258 timers/promises is a core module

[ljharb]

For tape, looks like node's error stacks now include a at processImmediate (node:internal/timers:$LINE:$COL) line where they didn't before - is that intentional and/or necessary?

[ljharb]

For resolve, v1.18.0 is now published; I believe that will pass the tests until new core modules are merged.

[BethGriggs]

For tape, looks like node's error stacks now include a at processImmediate (node:internal/timers:$LINE:$COL) line where they didn't before - is that intentional and/or necessary?

I have just found the PR that introduced the change, see nodejs/node#35498 (comment)

[ljharb]

It's not the node: part that i'm noticing tho; it's the extra line entirely.

[richardlau]

It's not the node: part that i'm noticing tho; it's the extra line entirely.

@ljharb It's the following line in tape's test that is affected by the node: part and no longer filtering out the line:
https://github.com/substack/tape/blob/898302b3e914c93b407088d36a224355b898bb0c/test/async-await.js#L184

> /\(internal\/timers.js:/.test('at processImmediate (internal/timers.js:462:21)')
true
> /\(internal\/timers.js:/.test('at processImmediate (node:internal/timers:462:21)')
false
>

[SimenB]

I'm assuming it's the same thing that made Jest fail: tapjs/stack-utils#54 (that probably wouldn't affect tape, but possibly tap?)

[richardlau]

I'm assuming it's the same thing that made Jest fail: tapjs/stack-utils#54 (that probably wouldn't affect tape, but possibly tap?)

Yes, looks like it. I've raised tapjs/stack-utils#55.

[ljharb]

@richardlau thanks for clarifying, it’s now fixed in the repo but not yet published.

[SimenB]

Thanks @richardlau!

[lpinca]

The problem with ws is that npm no longer installs the utf-8-validate dev dependency. Probably because it is also listed as optional peer dependency.

I'm not sure how to fix this.

Refs: npm/cli#1998

[lpinca]

ws issue is fixed in [email protected].

[targos]

Closing in favor of #852