Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor test/threadsafe_function/threadsafe_function.js with async/await #776

Closed
gabrielschulhof opened this issue Jul 25, 2020 · 5 comments
Closed

Refactor test/threadsafe_function/threadsafe_function.js with async/await #776

gabrielschulhof opened this issue Jul 25, 2020 · 5 comments
Labels
good first issue

Comments

@gabrielschulhof
Copy link
Contributor

Doing so would increase clarity.
@ghost
Copy link

ghost commented Jul 27, 2020

@gabrielschulhof I would like to try this one

@gabrielschulhof
Copy link
Contributor Author

Marking as "good first issue" because this does not involve changing the native code, but only the JS portion of the test.

@Velmisov
Copy link
Contributor

Velmisov commented Aug 4, 2020

@iandrc Are you still working on it, or can I take it?

@ghost
Copy link

ghost commented Aug 4, 2020 •
edited by ghost
Loading

Hey @Velmisov

It's WIP right now. I'll try to finish this one asap, just can't allocate enough time for this task right now.

Still, just go for it if you have some time :)
Just let me know in advance.

@Velmisov Velmisov mentioned this issue Aug 7, 2020
Closed
@mhdawson
Copy link
Member

Closing as its now complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gabrielschulhof @mhdawson @Velmisov