From a0020a9dc2d6c6216c45e9e5657faaf3e9d84174 Mon Sep 17 00:00:00 2001 From: Ferdinand Holzer Date: Sun, 24 May 2020 22:25:01 +0200 Subject: [PATCH 1/2] fix testEnumerables on ObjectWrap --- test/objectwrap.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/test/objectwrap.js b/test/objectwrap.js index a1a56136f..42a04199c 100644 --- a/test/objectwrap.js +++ b/test/objectwrap.js @@ -108,11 +108,11 @@ const test = (binding) => { keys.push(key); } - assert(keys.length = 4); - assert(obj.testGetSet); - assert(obj.testGetter); - assert(obj.testValue); - assert(obj.testMethod); + assert(keys.length == 6); + assert(keys.includes("testGetSet")); + assert(keys.includes("testGetter")); + assert(keys.includes("testValue")); + assert(keys.includes("testMethod")); } }; From 2405844c2bae0482d13494d42c1aecb1f3290742 Mon Sep 17 00:00:00 2001 From: Ferdinand Holzer Date: Sun, 31 May 2020 20:35:07 +0200 Subject: [PATCH 2/2] amend testEnumerables on ObjectWrap --- test/objectwrap.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/test/objectwrap.js b/test/objectwrap.js index 42a04199c..02abf60b9 100644 --- a/test/objectwrap.js +++ b/test/objectwrap.js @@ -109,10 +109,14 @@ const test = (binding) => { } assert(keys.length == 6); + // on prototype assert(keys.includes("testGetSet")); assert(keys.includes("testGetter")); assert(keys.includes("testValue")); assert(keys.includes("testMethod")); + // on object only + assert(keys.includes("ownProperty")); + assert(keys.includes("ownPropertyT")); } };