-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PRChecker: Check that semver-major commits have an explanation of breaking changes #108
Comments
Funnily enough, I saw this discussion, and thought "When this lands, this will be a perfect job for the pr_checker". Anyway: 👍 |
To me this is not the job for pr checker, but the job for core-validate-commit: checking commit messages. |
True! I had forgotten we had other tools 😄 |
It's not a trivial separation 🤔 - this might not be a simple formatting rule like what As I see it
IMHO such a failure should block the PR from being ready to land earlier, so that the lander could ask for more information from the author. |
@refack for now we should probably wait for |
@cPhost in term of ❌ / ✔️ I agree. |
This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made. |
Refs: nodejs/node#16846
The text was updated successfully, but these errors were encountered: