Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(git-node): prompt before attempting branch-diff #869

Merged
merged 1 commit into from
Nov 19, 2024
Merged

feat(git-node): prompt before attempting branch-diff #869

merged 1 commit into from
Nov 19, 2024

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 13, 2024

I hit this when preparing v18.20.5 during the collab summit, it seems like a good idea to use an interaction to help the releaser.

targos
targos approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always run the prepare command with --skipBranchDiff. I personally prefer to prepare and test the staging branch separately from the release proposal.

@aduh95 aduh95 merged commit 391487b into nodejs:main Nov 19, 2024
11 checks passed
@aduh95 aduh95 deleted the prompt-before-branch-diff branch November 19, 2024 16:16
@nodejs-github-bot nodejs-github-bot mentioned this pull request Nov 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aduh95 @targos