From fd7590c274ffd76451b88db933c588408f3c5abc Mon Sep 17 00:00:00 2001 From: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com> Date: Tue, 6 Aug 2024 18:27:34 -0400 Subject: [PATCH 1/3] fix: ignore codecov check suite --- lib/pr_checker.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/pr_checker.js b/lib/pr_checker.js index 7d00ca92..a51c2eb4 100644 --- a/lib/pr_checker.js +++ b/lib/pr_checker.js @@ -29,6 +29,7 @@ const GITHUB_SUCCESS_CONCLUSIONS = ['SUCCESS', 'NEUTRAL', 'SKIPPED']; const FAST_TRACK_RE = /^Fast-track has been requested by @(.+?)\. Please 👍 to approve\.$/; const FAST_TRACK_MIN_APPROVALS = 2; const GIT_CONFIG_GUIDE_URL = 'https://github.com/nodejs/node/blob/99b1ada/doc/guides/contributing/pull-requests.md#step-1-fork'; +const IGNORED_CHECK_SLUGS = ['dependabot', 'codecov']; // eslint-disable-next-line no-extend-native Array.prototype.findLastIndex ??= function findLastIndex(fn) { @@ -373,8 +374,8 @@ export default class PRChecker { // GitHub new Check API for (const { status, conclusion, app } of checkSuites.nodes) { - if (app && app.slug === 'dependabot') { - // Ignore Dependabot check suites. They are expected to show up + if (app && IGNORED_CHECK_SLUGS.includes(app.slug)) { + // Ignore app check suites. They are expected to show up // sometimes and never complete. continue; } From 72fa82698315b9cfce723ce5e800459481cf4da0 Mon Sep 17 00:00:00 2001 From: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com> Date: Wed, 7 Aug 2024 06:54:28 -0400 Subject: [PATCH 2/3] Update pr_checker.js Co-authored-by: Antoine du Hamel --- lib/pr_checker.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/pr_checker.js b/lib/pr_checker.js index a51c2eb4..b1a03132 100644 --- a/lib/pr_checker.js +++ b/lib/pr_checker.js @@ -375,7 +375,7 @@ export default class PRChecker { // GitHub new Check API for (const { status, conclusion, app } of checkSuites.nodes) { if (app && IGNORED_CHECK_SLUGS.includes(app.slug)) { - // Ignore app check suites. They are expected to show up + // Ignore GitHub Apps check suites. They are expected to show up // sometimes and never complete. continue; } From d74e0ec619a8b50c236e3631130d2a2c1aa30f1d Mon Sep 17 00:00:00 2001 From: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com> Date: Wed, 7 Aug 2024 10:44:26 -0400 Subject: [PATCH 3/3] Update pr_checker.js --- lib/pr_checker.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/pr_checker.js b/lib/pr_checker.js index b1a03132..b37314e4 100644 --- a/lib/pr_checker.js +++ b/lib/pr_checker.js @@ -375,8 +375,8 @@ export default class PRChecker { // GitHub new Check API for (const { status, conclusion, app } of checkSuites.nodes) { if (app && IGNORED_CHECK_SLUGS.includes(app.slug)) { - // Ignore GitHub Apps check suites. They are expected to show up - // sometimes and never complete. + // Ignore Dependabot and Codecov check suites. + // They are expected to show up sometimes and never complete. continue; }