test: added net.connect lookup type check

Check the options passed to Socket.prototype.connect() to validate the type of the lookup property. PR-URL: #11873 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
nodejs · Jul 11, 2017 · 186c075 · 186c075
1 parent 1609c7f
commit 186c075
Showing 1 changed file with 34 additions and 0 deletions.
diff --git a/test/parallel/test-net-options-lookup.js b/test/parallel/test-net-options-lookup.js
@@ -0,0 +1,34 @@
+'use strict';
+const common = require('../common');
+const assert = require('assert');
+const net = require('net');
+
+const expectedError = /^TypeError: "lookup" option should be a function$/;
+
+['foobar', 1, {}, []].forEach((input) => connectThrows(input));
+
+function connectThrows(input) {
+  const opts = {
+    host: 'localhost',
+    port: common.PORT,
+    lookup: input
+  };
+
+  assert.throws(function() {
+    net.connect(opts);
+  }, expectedError);
+}
+
+[() => {}].forEach((input) => connectDoesNotThrow(input));
+
+function connectDoesNotThrow(input) {
+  const opts = {
+    host: 'localhost',
+    port: common.PORT,
+    lookup: input
+  };
+
+  assert.doesNotThrow(function() {
+    net.connect(opts);
+  });
+}