From 31995e4cd291de045fd1bf0b5e3a831b6645353a Mon Sep 17 00:00:00 2001 From: Ruben Bridgewater Date: Thu, 14 Mar 2019 12:36:59 +0100 Subject: [PATCH] test: fix intrinsics test MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit So far this test did not verify that the call did indeed fail since the error case was not checked. This makes sure the error is indeed thrown as expected. PR-URL: https://github.com/nodejs/node/pull/26660 Reviewed-By: Michaƫl Zasso Reviewed-By: Richard Lau Reviewed-By: Denys Otrishko Reviewed-By: Luigi Pinca Reviewed-By: Rich Trott --- test/parallel/test-freeze-intrinsics.js | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/test/parallel/test-freeze-intrinsics.js b/test/parallel/test-freeze-intrinsics.js index bb94946d2d0f3c..19e5319286371f 100644 --- a/test/parallel/test-freeze-intrinsics.js +++ b/test/parallel/test-freeze-intrinsics.js @@ -3,8 +3,7 @@ require('../common'); const assert = require('assert'); -try { - Object.defineProperty = 'asdf'; - assert(false); -} catch { -} +assert.throws( + () => Object.defineProperty = 'asdf', + TypeError +);