From 456f76a48b65cc03c492a895975640cf13ab5a7f Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Thu, 3 Jan 2019 10:34:17 -0800 Subject: [PATCH] test: remove flag for test-addon-uv-handle-leak test-addon-uv-handle-leak only requires worker_threads for the subprocess which it explicitly calls with --experimental-worker. The main test itself does not need it. Remove Flags: comment and move loading of worker_threads into subprocess-only logic. PR-URL: https://github.com/nodejs/node/pull/25327 Reviewed-By: Colin Ihrig Reviewed-By: Luigi Pinca Reviewed-By: Michael Dawson Reviewed-By: Daijiro Wachi Reviewed-By: James M Snell --- test/abort/test-addon-uv-handle-leak.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/abort/test-addon-uv-handle-leak.js b/test/abort/test-addon-uv-handle-leak.js index b67c5f7136af6e..87affeebf20c96 100644 --- a/test/abort/test-addon-uv-handle-leak.js +++ b/test/abort/test-addon-uv-handle-leak.js @@ -1,11 +1,9 @@ -// Flags: --experimental-worker 'use strict'; const common = require('../common'); const assert = require('assert'); const fs = require('fs'); const path = require('path'); const cp = require('child_process'); -const { Worker } = require('worker_threads'); const { spawnSync } = require('child_process'); // This is a sibling test to test/addons/uv-handle-leak. @@ -19,6 +17,8 @@ if (!fs.existsSync(bindingPath)) if (process.argv[2] === 'child') { + const { Worker } = require('worker_threads'); + // The worker thread loads and then unloads `bindingPath`. Because of this the // symbols in `bindingPath` are lost when the worker thread quits, but the // number of open handles in the worker thread's event loop is assessed in the