test: refactor async-hooks/test-httparser tests

CRLF variable was defined but only used on line 22 so the variable was deleted and placed inside line 22 as a string literal. This was in file test-httpparser.request.js On line 46 there's a function declared that takes 3 arguments but none of them are ever used so removed. This is in file test-httpparser.response.js PR-URL: #14818 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Sep 12, 2017 · 4dd095c · 4dd095c
1 parent 9589641
commit 4dd095c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/test/async-hooks/test-httpparser.request.js b/test/async-hooks/test-httpparser.request.js
@@ -9,7 +9,6 @@ const { checkInvocations } = require('./hook-checks');
 const binding = process.binding('http_parser');
 const HTTPParser = binding.HTTPParser;
 
-const CRLF = '\r\n';
 const REQUEST = HTTPParser.REQUEST;
 
 const kOnHeadersComplete = HTTPParser.kOnHeadersComplete | 0;
@@ -19,7 +18,7 @@ const hooks = initHooks();
 hooks.enable();
 
 const request = Buffer.from(
-  'GET /hello HTTP/1.1' + CRLF + CRLF
+  'GET /hello HTTP/1.1\r\n\r\n'
 );
 
 const parser = new HTTPParser(REQUEST);

diff --git a/test/async-hooks/test-httpparser.response.js b/test/async-hooks/test-httpparser.response.js
@@ -43,7 +43,7 @@ function onheadersComplete() {
                    'when onheadersComplete called');
 }
 
-function onbody(buf, start, len) {
+function onbody() {
   checkInvocations(httpparser, { init: 1, before: 2, after: 1 },
                    'when onbody called');
   tick(1, common.mustCall(tick1));