From a63db7fb5ebade4d82a16bfab426108b0cbc192e Mon Sep 17 00:00:00 2001 From: Clemens Backes Date: Thu, 6 Feb 2020 09:23:53 +0100 Subject: [PATCH] src: remove deprecated wasm type check MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This removes uses of the "IsWebAssemblyCompiledModule" method, which is deprecated in V8 v8.1 and will be removed in v8.2. We could replace it by "IsWasmModuleObject", but since it's unused in node anyway, I just remove the definition. PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By: Michaƫl Zasso Reviewed-By: Jiawen Geng Reviewed-By: Ruben Bridgewater --- doc/api/util.md | 3 +++ src/node_types.cc | 1 - 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/doc/api/util.md b/doc/api/util.md index 2c0062eff7b62f..53fce825440aa0 100644 --- a/doc/api/util.md +++ b/doc/api/util.md @@ -1891,8 +1891,11 @@ util.types.isWeakSet(new WeakSet()); // Returns true ### `util.types.isWebAssemblyCompiledModule(value)` +> Stability: 0 - Deprecated: Use `value instanceof WebAssembly.Module` instead. + * `value` {any} * Returns: {boolean} diff --git a/src/node_types.cc b/src/node_types.cc index a53bcba555448f..9643a66668144e 100644 --- a/src/node_types.cc +++ b/src/node_types.cc @@ -35,7 +35,6 @@ namespace { V(DataView) \ V(SharedArrayBuffer) \ V(Proxy) \ - V(WebAssemblyCompiledModule) \ V(ModuleNamespaceObject) \