From ada3f34cd4082454edef127c534c16579256c535 Mon Sep 17 00:00:00 2001 From: Jon Moss Date: Fri, 13 Jul 2018 10:45:42 -0400 Subject: [PATCH] test: fix weird string error Previously getting this error when running `tap2junit` (what parses our `.tap` files in CI): ``` Traceback (most recent call last): File "/usr/local/bin/tap2junit", line 11, in sys.exit(main()) File "/usr/local/lib/python2.7/site-packages/tap2junit/__main__.py", line 46, in main result.to_file(args.output, [result], prettyprint=False) File "/usr/local/lib/python2.7/site-packages/junit_xml/__init__.py", line 289, in to_file test_suites, prettyprint=prettyprint, encoding=encoding) File "/usr/local/lib/python2.7/site-packages/junit_xml/__init__.py", line 257, in to_xml_string ts_xml = ts.build_xml_doc(encoding=encoding) File "/usr/local/lib/python2.7/site-packages/junit_xml/__init__.py", line 221, in build_xml_doc attrs['message'] = decode(case.skipped_message, encoding) File "/usr/local/lib/python2.7/site-packages/junit_xml/__init__.py", line 68, in decode ret = unicode(var) UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 11: ordinal not in range(128) ``` PR-URL: https://github.com/nodejs/node/pull/21793 Reviewed-By: Anna Henningsen Reviewed-By: Luigi Pinca --- test/parallel/test-stdio-pipe-access.js | 2 +- test/parallel/test-stdio-pipe-redirect.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/test/parallel/test-stdio-pipe-access.js b/test/parallel/test-stdio-pipe-access.js index d32c5f0ba9c2e7..084fa4c038e7da 100644 --- a/test/parallel/test-stdio-pipe-access.js +++ b/test/parallel/test-stdio-pipe-access.js @@ -1,7 +1,7 @@ 'use strict'; const common = require('../common'); if (!common.isMainThread) - common.skip('Workers don’t have process-like stdio'); + common.skip("Workers don't have process-like stdio"); // Test if Node handles acessing process.stdin if it is a redirected // pipe without deadlocking diff --git a/test/parallel/test-stdio-pipe-redirect.js b/test/parallel/test-stdio-pipe-redirect.js index 60f16b5cb2f6df..fbde6ef8085457 100644 --- a/test/parallel/test-stdio-pipe-redirect.js +++ b/test/parallel/test-stdio-pipe-redirect.js @@ -1,7 +1,7 @@ 'use strict'; const common = require('../common'); if (!common.isMainThread) - common.skip('Workers don’t have process-like stdio'); + common.skip("Workers don't have process-like stdio"); // Test if Node handles redirecting one child process stdout to another // process stdin without crashing.