From dd3f94873ec2b8c497c4624a642b24c992ba6efb Mon Sep 17 00:00:00 2001
From: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com>
Date: Fri, 10 Jan 2025 13:44:43 +0000
Subject: [PATCH] esm: fix jsdoc type refs to `ModuleJobBase` in esm/loader

Co-Authored-By: Carlos Espa <43477095+Ceres6@users.noreply.github.com>
PR-URL: https://github.com/nodejs/node/pull/56499
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
---
 lib/internal/modules/esm/loader.js | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/lib/internal/modules/esm/loader.js b/lib/internal/modules/esm/loader.js
index 19eac728623939..a3b437ade87c75 100644
--- a/lib/internal/modules/esm/loader.js
+++ b/lib/internal/modules/esm/loader.js
@@ -54,6 +54,8 @@ const { tracingChannel } = require('diagnostics_channel');
 const onImport = tracingChannel('module.import');
 
 /**
+ * @typedef {import('./hooks.js').HooksProxy} HooksProxy
+ * @typedef {import('./module_job.js').ModuleJobBase} ModuleJobBase
  * @typedef {import('url').URL} URL
  */
 
@@ -149,6 +151,7 @@ class ModuleLoader {
    *  to this property and failure to do so will cause undefined
    * behavior when invoking `import.meta.resolve`.
    * @see {ModuleLoader.setCustomizations}
+   * @type {CustomizedModuleLoader}
    */
   #customizations;
 
@@ -202,7 +205,7 @@ class ModuleLoader {
    *
    * Calling this function alters how modules are loaded and should be
    * invoked with care.
-   * @param {object} customizations
+   * @param {CustomizedModuleLoader} customizations
    */
   setCustomizations(customizations) {
     this.#customizations = customizations;
@@ -270,7 +273,7 @@ class ModuleLoader {
    * @param {string} [parentURL] The URL of the module where the module request is initiated.
    *                             It's undefined if it's from the root module.
    * @param {ImportAttributes} importAttributes Attributes from the import statement or expression.
-   * @returns {Promise<ModuleJobBase}
+   * @returns {Promise<ModuleJobBase>}
    */
   async getModuleJobForImport(specifier, parentURL, importAttributes) {
     const resolveResult = await this.resolve(specifier, parentURL, importAttributes);
@@ -284,7 +287,7 @@ class ModuleLoader {
    * @param {string} specifier See {@link getModuleJobForImport}
    * @param {string} [parentURL] See {@link getModuleJobForImport}
    * @param {ImportAttributes} importAttributes See {@link getModuleJobForImport}
-   * @returns {Promise<ModuleJobBase}
+   * @returns {Promise<ModuleJobBase>}
    */
   getModuleJobForRequireInImportedCJS(specifier, parentURL, importAttributes) {
     const resolveResult = this.resolveSync(specifier, parentURL, importAttributes);
@@ -678,7 +681,7 @@ class ModuleLoader {
   /**
    * Similar to {@link resolve}, but the results are always synchronously returned. If there are any
    * asynchronous resolve hooks from module.register(), it will block until the results are returned
-   * from the loader thread for this to be synchornous.
+   * from the loader thread for this to be synchronous.
    * This is here to support `import.meta.resolve()`, `require()` in imported CJS, and
    * `module.registerHooks()` hooks.
    *