stream: improve Writable.destroy performance

Avoid nextTick if there are no pending callbacks. PR-URL: #35067 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ricky Zhou <[email protected]>
nodejs · Sep 7, 2020 · e0d3b75 · e0d3b75
1 parent e06037a
commit e0d3b75
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/lib/_stream_writable.js b/lib/_stream_writable.js
@@ -45,6 +45,7 @@ const {
   getHighWaterMark,
   getDefaultHighWaterMark
 } = require('internal/streams/state');
+const assert = require('internal/assert');
 const {
   ERR_INVALID_ARG_TYPE,
   ERR_METHOD_NOT_IMPLEMENTED,
@@ -826,9 +827,16 @@ ObjectDefineProperties(Writable.prototype, {
 const destroy = destroyImpl.destroy;
 Writable.prototype.destroy = function(err, cb) {
   const state = this._writableState;
-  if (!state.destroyed) {
+
+  // Invoke pending callbacks.
+  if (
+    state.bufferedIndex < state.buffered.length ||
+    state[kOnFinished].length
+  ) {
+    assert(!state.destroyed);
     process.nextTick(errorBuffer, state);
   }
+
   destroy.call(this, err, cb);
   return this;
 };