deps: V8: Add virtual dtor to avoid aix gcc error

deps/v8/src/torque/file-visitor.h: * Not currently present in v8/master deps/v8/third_party/antlr4/BUILD.gn: * Use current_os variable to avoid is_aix being undefined. The following patch to v8/build solves this issue for v8/master: * a1a12ef3b343f9e75c630ed6dc8f1ea44a8a747b However, the version of '/chromium/src/build.git' cannot be updated to include this patch in v8/DEPS file. (could potentially cause issues for other platforms) The change to deps/v8/src/torque/file-visitor.h is a workaround for origin/v10.x-staging branch. PR-URL: #23695 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Yang Guo <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
nodejs · Nov 29, 2018 · e231bf5 · e231bf5
1 parent 1bea8db
commit e231bf5
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/common.gypi b/common.gypi
@@ -33,7 +33,7 @@
 
     # Reset this number to 0 on major V8 upgrades.
     # Increment by one for each non-official patch applied to deps/v8.
-    'v8_embedder_string': '-node.43',
+    'v8_embedder_string': '-node.44',
 
     # Enable disassembler for `--print-code` v8 options
     'v8_enable_disassembler': 1,

diff --git a/deps/v8/src/torque/file-visitor.h b/deps/v8/src/torque/file-visitor.h
@@ -21,6 +21,10 @@ namespace torque {
 
 class FileVisitor {
  public:
+#if defined(__GNUC__) && V8_OS_AIX
+  // prevent non-virtual-dtor gcc error on Aix
+  virtual ~FileVisitor() = default;
+#endif
   explicit FileVisitor(GlobalContext& global_context)
       : global_context_(global_context),
         declarations_(global_context.declarations()),

diff --git a/deps/v8/third_party/antlr4/BUILD.gn b/deps/v8/third_party/antlr4/BUILD.gn
@@ -9,7 +9,7 @@ config("antlr-compatibility") {
       "-Wno-unused-but-set-variable",
     ]
   }
-  if (is_aix) {
+  if (current_os == "aix") {
     cflags += [ "-fdollars-in-identifiers" ]
   }
 }