deps: update v8_inspector

Pick the latest v8_inspector [1] with: * V8 5.1 compatibility * Modify parse builder templates to make coverity happy * The whitespace differences in the jinja2 sub-dependency do exist upstream. I am not sure how I missed them in the original import (ed2eac). [1] pavelfeldman/v8_inspector@3b56732 PR-URL: #7118 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
nodejs · Jul 5, 2016 · f4777c7 · f4777c7
1 parent 643b33b
commit f4777c7
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 3 deletions.
diff --git a/deps/v8_inspector/platform/inspector_protocol/CodeGenerator.py b/deps/v8_inspector/platform/inspector_protocol/CodeGenerator.py
@@ -180,6 +180,11 @@ def create_primitive_type_definition(type):
         "integer": "int",
         "boolean": "bool"
     }
+    defaults = {
+        "number": "0",
+        "integer": "0",
+        "boolean": "false"
+    }
     jsontypes = {
         "number": "TypeNumber",
         "integer": "TypeNumber",
@@ -195,6 +200,7 @@ def create_primitive_type_definition(type):
         "raw_type": typedefs[type],
         "raw_pass_type": typedefs[type],
         "raw_return_type": typedefs[type],
+        "default_value": defaults[type]
     }
 
 type_definitions = {}

diff --git a/deps/v8_inspector/platform/inspector_protocol/TypeBuilder_h.template b/deps/v8_inspector/platform/inspector_protocol/TypeBuilder_h.template
@@ -187,7 +187,14 @@ public:
     }
 
 private:
-    {{type.id}}() { }
+    {{type.id}}()
+    {
+    {% for property in type.properties %}
+      {% if not(property.optional) and "default_value" in resolve_type(property) %}
+          m_{{property.name}} = {{resolve_type(property).default_value}};
+      {%endif %}
+    {% endfor %}
+    }
 
     {% for property in type.properties %}
       {% if property.optional %}

diff --git a/deps/v8_inspector/platform/v8_inspector/V8Compat.h b/deps/v8_inspector/platform/v8_inspector/V8Compat.h
@@ -7,7 +7,7 @@
 
 #include <v8.h>
 
-#if V8_MAJOR_VERSION < 5 || (V8_MAJOR_VERSION == 5 && V8_MINOR_VERSION < 2)
+#if V8_MAJOR_VERSION < 5 || (V8_MAJOR_VERSION == 5 && V8_MINOR_VERSION < 1)
 namespace v8 {
 
 // In standalone V8 inspector this is expected to be noop anyways...
@@ -23,6 +23,6 @@ class V8_EXPORT MicrotasksScope {
 
 } // namespace v8
 
-#endif // V8_MAJOR_VERSION < 5 || (V8_MAJOR_VERSION == 5 && V8_MINOR_VERSION < 2)
+#endif // V8_MAJOR_VERSION < 5 || (V8_MAJOR_VERSION == 5 && V8_MINOR_VERSION < 1)
 
 #endif // V8Compat_h