socket emit 'error' twice

[ronag]

I'm getting error emitted twice from the same object?

Version: v10.0.0
Platform: Darwin Roberts-MacBook-Pro-2.local 17.5.0 Darwin Kernel Version 17.5.0: Mon Mar 5 22:24:32 PST 2018; root:xnu-4570.51.1~1/RELEASE_X86_64 x86_64

Error: connect ECONNREFUSED 127.0.0.1:6020
  at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1161:14)

and

Error: read ECONNRESET
  at TLSWrap.onread (net.js:659:25) errno: 'ECONNRESET', code: 'ECONNRESET', syscall: 'read' }

Seems like a bug?

[addaleax]

Seems like a bug?

I agree, if error is being emitted twice that’s a bug.

Can you provide the information from the issue template?

[ronag]

I don't have a reproducible case. Got this from the logs in our production servers.

[ronag]

I think it´s a TCPConnectWrap && TLSWrap issue where TCPConnectWrap destroy's itself with an error and then destroys the TLSWrap with an error and then forwards the TLSWrap error up the chain.

After TCPConnectWrap.destroy errors from TLSWrap should be swallowed, no?

[ronag]

This error does not occur in node 9. Just in node 10.

[ronag]

Node 10:

ERROR: upgrade failed
    proxyName: "nxt"
    req: {
      "method": "GET",
      "url": "/deepstream"
    }
    err: {
      "type": "Error",
      "message": "connect ECONNREFUSED 127.0.0.1:6020",
      "stack":
          Error: connect ECONNREFUSED 127.0.0.1:6020
              at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1161:14)
      "errno": "ECONNREFUSED",
      "code": "ECONNREFUSED",
      "syscall": "connect",
      "address": "127.0.0.1",
      "port": 6020,
      "statusCode": 503
    }
ERROR: uncaught exception
    err: {
      "type": "Error",
      "message": "read ECONNRESET",
      "stack":
          Error: read ECONNRESET
              at TLSWrap.onread (net.js:659:25)
      "errno": "ECONNRESET",
      "code": "ECONNRESET",
      "syscall": "read"
    }

Node 9:

ERROR: session error
    err: {
      "type": "Error",
      "message": "read ECONNRESET",
      "stack":
          Error: read ECONNRESET
              at TLSWrap.onread (net.js:602:25)
      "errno": "ECONNRESET",
      "code": "ECONNRESET",
      "syscall": "read"
    }
ERROR: upgrade failed
    proxyName: "nxt"
    req: {
      "method": "GET",
      "url": "/deepstream"
    }
    err: {
      "type": "Error",
      "message": "connect ECONNREFUSED 127.0.0.1:6020",
      "stack":
          Error: connect ECONNREFUSED 127.0.0.1:6020
              at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1174:14)
      "errno": "ECONNREFUSED",
      "code": "ECONNREFUSED",
      "syscall": "connect",
      "address": "127.0.0.1",
      "port": 6020,
      "statusCode": 503
    }

[apapirovski]

@ronag what did you end up finding out?

[ronag]

@apapirovski: the behaviour is different between node 9 and 10. Not quite sure how.

I was basically doing things wrong. I didn't expect to get an error after calling socket.end().

[addaleax]

@ronag Maybe this is #20334?