Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.exe builds not manifested #2617

Closed
silverwind opened this issue Aug 30, 2015 · 4 comments
Closed

.exe builds not manifested #2617

silverwind opened this issue Aug 30, 2015 · 4 comments
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.

Comments

@silverwind
Copy link
Contributor

The .exe builds at https://iojs.org/download/release/latest/win-x86/ seem to not be manifested and in turn do not benefit from #2332. On Window 10, os.release() reports 6.2.9200 which is the default for unmanifested builds. The binaries provided by installer are reporting the correct version 10.0.10240.

cc: @orangemocha

@silverwind silverwind added windows Issues and PRs related to the Windows platform. build Issues and PRs related to build files or the CI. labels Aug 30, 2015
@silverwind
Copy link
Contributor Author

Wild guess, but could it be because the msbuild task (which presumably builds the exe files) is missing a few switches compared to the msibuild?

@silverwind silverwind changed the title .exe builds no manifested for Windows 10 .exe builds not manifested Aug 30, 2015
@orangemocha
Copy link
Contributor

cc @joaocgreis , who I know was working on a fix.

@joaocgreis
Copy link
Member

@silverwind for version 3.0.0 it is indeed broken, but for 3.1.0 onwards it works. Can you confirm if this is working for new versions for you?

@silverwind
Copy link
Contributor Author

Yeah, looks to be working indeed, sorry about that.

screen shot 2015-09-11 at 8 02 36 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

No branches or pull requests

3 participants