Socket.connect results in an abort in v12.x and v10.x

[zyscoder]

• Version: v12.21.0 & v10.24.0
• Platform: Linux 5.8.0-38-generic The binary and long term compatibility with node #43~20.04.1-Ubuntu SMP Tue Jan 12 16:39:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
• Subsystem: Socket.connect

What steps will reproduce the bug?

Setup a node instance,

» node

and run the following javascript code.

socket = new net.Socket({fd:10});
new net.Socket({fd:10}).resume();
socket.connect('str',()=>{});

Then an abort occurs.

How often does it reproduce? Is there a required condition?

This problem can always be triggered following the steps above.

What is the expected behavior?

If any error occurs, an exception or other similar error-reporting stuff should be thrown. There is no reason to abort the whole node process.

What do you see instead?

» node
Welcome to Node.js v12.21.0.
Type ".help" for more information.
> socket = new net.Socket({fd:10});
Socket {
...
}
> new net.Socket({fd:10}).resume();
Socket {
...
}
> socket.connect('str',()=>{});
Socket {
...
}
> node: ../deps/uv/src/unix/core.c:930: uv__io_stop: Assertion `loop->watchers[w->fd] == w' failed.
[2]    3060074 abort      /home/zys/Toolchains/node-v12.21.0/node

Additional information

[EladKeyshawn]

@zyscoder Is this normal on OSX ? (trying to reproduce the problem)

> socket = new net.Socket({fd:10});
Uncaught Error: ENOTTY: inappropriate ioctl for device, uv_pipe_open
    at new Socket (node:net:320:24) {
  errno: -25,
  code: 'ENOTTY',
  syscall: 'uv_pipe_open'
}

Edit:
Another fd=4 works...

[EladKeyshawn]

@marsonya This problem is fixed with latest 'uv' dep (v1.41.0 ), should I created a PR to upgrade 'uv' at 10.x and 12.x branches ?

[targos]

v10.x is not going to have another release before EoL (end of this month).
It may still make sense to upgrade libuv in v12.x, but it should ideally only happend after we do it in v14.x.

[jasnell]

Given that 10x is reaching end of life and won't be seeing another release. Removing the 10x label.

[santigimeno]

Already fixed as the libuv version in v14.21.1 is 1.42.0