CDP setBlackboxPatterns no longer applies to Node internals

[connor4312]

Version

v20.8.0

Platform

Darwin mbp.peet.io 22.6.0 Darwin Kernel Version 22.6.0: Fri Sep 15 13:39:52 PDT 2023; root:xnu-8796.141.3.700.8~1/RELEASE_X86_64 x86_64

Subsystem

inspector

What steps will reproduce the bug?

1. Have a file like console.log('hello');\nconsole.log('goodbye');
2. Run with node --inspect-brk, and attach Chrome devtools to the process using chrome:///inspect
3. Run Show Ignore List and add node: to that list. This regex should match, and skip, all Node internals (via setBlackboxPattern)
4. Step in

How often does it reproduce? Is there a required condition?

100%

What is the expected behavior? Why is that the expected behavior?

I expect the debugger to stop on the next console.log('goodbye'), or at least try to.

What do you see instead?

The blackbox does not apply at all, and the debugger steps directly into the console call without trying to escape.

Additional information

This appears to have been broken since Node 16 in the migration to the node: prefix

[bnoordhuis]

I don't think this is a node bug. Blackboxing isn't handled inside node at all. More likely it's a V8 bug or, less likely, a devtools bug.

FWIW, the inspector essentially calls new RegExp() and then invokes Regexp.prototype.exec. It's quite possibly not robust against prototype tampering.

[bnoordhuis]

I'm going to go ahead and close this but LMK if something needs to be done on our side.