Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

path, doc: More examples for path.format() #5747

Closed
Trott opened this issue Mar 16, 2016 · 3 comments
Closed

path, doc: More examples for path.format() #5747

Trott opened this issue Mar 16, 2016 · 3 comments
Labels
doc Issues and PRs related to the documentations. path Issues and PRs related to the path subsystem.

Comments

@Trott
Copy link
Member

Trott commented Mar 16, 2016

The doc for path.format() has a bunch of details about the algorithm. Example code that demonstrates the different elements of the explanation would be useful. For example: An example of what happens if the pathObject argument does not have a dir property.

This is a good first contribution for someone looking to get familiar with the contribution process.

@Trott Trott added doc Issues and PRs related to the documentations. path Issues and PRs related to the path subsystem. good first issue Issues that are suitable for first-time contributors. labels Mar 16, 2016
@eversojk
Copy link
Contributor

I can take a look at this tomorrow if it's still available.

@Trott
Copy link
Member Author

Trott commented Mar 21, 2016

Looks like we have a PR for this. Going to remove the good first contribution so no one else tries to pick it up!

@Trott Trott removed the good first issue Issues that are suitable for first-time contributors. label Mar 21, 2016
@jasnell
Copy link
Member

jasnell commented Apr 12, 2016

PR landed! Closing

@jasnell jasnell closed this as completed Apr 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. path Issues and PRs related to the path subsystem.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants