From 7e75d8fdf0cb9dc245fe0a70d616e3cb76b46ab1 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Sat, 17 Feb 2018 19:25:07 -0800 Subject: [PATCH 1/2] doc: update onboarding.md for faster exercise completion Note that the CI run for the exercise can be minimal. --- doc/onboarding.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/doc/onboarding.md b/doc/onboarding.md index 296f9db7d02ef8..7fbeed70b4e0f2 100644 --- a/doc/onboarding.md +++ b/doc/onboarding.md @@ -200,7 +200,9 @@ onboarding session. * Collaborators are in alphabetical order by GitHub username. * Optionally, include your personal pronouns. * Label your pull request with the `doc` subsystem label. -* Run CI on your PR. +* Run CI on the PR. Because the PR does not affect any code, use either the + `node-test-pull-request-lite` CI task or else cancel the CI run after the + linter and one other subtask have passed. * After one or two approvals, land the PR (PRs of this type do not need to wait for 48/72 hours to land). * Be sure to add the `PR-URL: ` and appropriate `Reviewed-By:` From 78e1b43a7908ec10a7e4cd0ae768ec529ddff3f7 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Sun, 18 Feb 2018 14:36:30 -0800 Subject: [PATCH 2/2] squash: maclover7 request --- doc/onboarding.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/doc/onboarding.md b/doc/onboarding.md index 7fbeed70b4e0f2..e2a05f2ccd17eb 100644 --- a/doc/onboarding.md +++ b/doc/onboarding.md @@ -200,9 +200,10 @@ onboarding session. * Collaborators are in alphabetical order by GitHub username. * Optionally, include your personal pronouns. * Label your pull request with the `doc` subsystem label. -* Run CI on the PR. Because the PR does not affect any code, use either the - `node-test-pull-request-lite` CI task or else cancel the CI run after the - linter and one other subtask have passed. +* Run CI on the PR. Because the PR does not affect any code, use the + `node-test-pull-request-lite` CI task. Alternatively, use the usual + `node-test-pull-request` CI task and cancel it after the linter and one other + subtask have passed. * After one or two approvals, land the PR (PRs of this type do not need to wait for 48/72 hours to land). * Be sure to add the `PR-URL: ` and appropriate `Reviewed-By:`