From 96cdd47fd970c0a0bca049d4a47898e8751cac73 Mon Sep 17 00:00:00 2001 From: James M Snell Date: Mon, 17 Feb 2020 05:53:31 -0800 Subject: [PATCH 1/2] doc: clarify http2.connect authority details Fixes: https://github.com/nodejs/node/issues/31827 --- doc/api/http2.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/doc/api/http2.md b/doc/api/http2.md index e022b39f044d53..1a1fdfe7bbf586 100644 --- a/doc/api/http2.md +++ b/doc/api/http2.md @@ -2206,7 +2206,10 @@ changes: 128 header pairs. --> -* `authority` {string|URL} +* `authority` {string|URL} The remote HTTP/2 server to connect to. This must + be in the form of a minimal, valid URL with the `http://` or `https://` prefix, + host name, and IP port (if a non-default port is used). Userinfo (user ID and + password), path, querystring, and fragment details in the URL will be ignored. * `options` {Object} * `maxDeflateDynamicTableSize` {number} Sets the maximum dynamic table size for deflating header fields. **Default:** `4Kib`. From 3d1bdb4a369e2648a27908d22c347d5cd1a05061 Mon Sep 17 00:00:00 2001 From: James M Snell Date: Wed, 26 Feb 2020 15:38:22 -0800 Subject: [PATCH 2/2] [Squash] lint nit --- doc/api/http2.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/doc/api/http2.md b/doc/api/http2.md index 1a1fdfe7bbf586..11f41224c4e1d3 100644 --- a/doc/api/http2.md +++ b/doc/api/http2.md @@ -2207,9 +2207,10 @@ changes: --> * `authority` {string|URL} The remote HTTP/2 server to connect to. This must - be in the form of a minimal, valid URL with the `http://` or `https://` prefix, - host name, and IP port (if a non-default port is used). Userinfo (user ID and - password), path, querystring, and fragment details in the URL will be ignored. + be in the form of a minimal, valid URL with the `http://` or `https://` + prefix, host name, and IP port (if a non-default port is used). Userinfo + (user ID and password), path, querystring, and fragment details in the + URL will be ignored. * `options` {Object} * `maxDeflateDynamicTableSize` {number} Sets the maximum dynamic table size for deflating header fields. **Default:** `4Kib`.