From 505f3e864ce03fae3c50320a266e516678d05028 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tobias=20Nie=C3=9Fen?= Date: Wed, 19 Feb 2020 10:47:14 -0400 Subject: [PATCH] crypto: make DH error messages consistent Refs: https://github.com/nodejs/node/pull/31178 Refs: https://github.com/nodejs/node/pull/31445 --- src/node_crypto.cc | 2 +- test/parallel/test-crypto-dh.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/node_crypto.cc b/src/node_crypto.cc index 2176fffc543e0b..2a3f122d0530a9 100644 --- a/src/node_crypto.cc +++ b/src/node_crypto.cc @@ -5690,7 +5690,7 @@ void DiffieHellman::DiffieHellmanGroup( const node::Utf8Value group_name(env->isolate(), args[0]); const modp_group* group = FindDiffieHellmanGroup(*group_name); if (group == nullptr) - return THROW_ERR_CRYPTO_UNKNOWN_DH_GROUP(env, "Unknown group"); + return THROW_ERR_CRYPTO_UNKNOWN_DH_GROUP(env); initialized = diffieHellman->Init(group->prime, group->prime_size, diff --git a/test/parallel/test-crypto-dh.js b/test/parallel/test-crypto-dh.js index 7824800f9bee2e..baa7402a88fdb6 100644 --- a/test/parallel/test-crypto-dh.js +++ b/test/parallel/test-crypto-dh.js @@ -392,7 +392,7 @@ assert.throws( { name: 'Error', code: 'ERR_CRYPTO_UNKNOWN_DH_GROUP', - message: 'Unknown group' + message: 'Unknown DH group' }, 'crypto.getDiffieHellman(\'unknown-group\') ' + 'failed to throw the expected error.'