diff --git a/.github/workflows/coverage-linux-without-intl.yml b/.github/workflows/coverage-linux-without-intl.yml index d3dc4baf78e3d5..e26d7a99533898 100644 --- a/.github/workflows/coverage-linux-without-intl.yml +++ b/.github/workflows/coverage-linux-without-intl.yml @@ -12,6 +12,7 @@ on: - tools/gyp/** - tools/test.py - .github/workflows/coverage-linux-without-intl.yml + - codecov.yml push: branches: - main @@ -24,6 +25,7 @@ on: - tools/gyp/** - tools/test.py - .github/workflows/coverage-linux-without-intl.yml + - codecov.yml concurrency: group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }} diff --git a/.github/workflows/coverage-linux.yml b/.github/workflows/coverage-linux.yml index 79f1f89470d41a..63b523638b126b 100644 --- a/.github/workflows/coverage-linux.yml +++ b/.github/workflows/coverage-linux.yml @@ -12,6 +12,7 @@ on: - tools/gyp/** - tools/test.py - .github/workflows/coverage-linux.yml + - codecov.yml push: branches: - main @@ -24,6 +25,7 @@ on: - tools/gyp/** - tools/test.py - .github/workflows/coverage-linux.yml + - codecov.yml concurrency: group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }} diff --git a/.github/workflows/coverage-windows.yml b/.github/workflows/coverage-windows.yml index 686748b5173612..cdaaa3563904fa 100644 --- a/.github/workflows/coverage-windows.yml +++ b/.github/workflows/coverage-windows.yml @@ -12,6 +12,7 @@ on: - tools/gyp/** - tools/test.py - .github/workflows/coverage-windows.yml + - codecov.yml push: branches: - main @@ -24,6 +25,7 @@ on: - tools/gyp/** - tools/test.py - .github/workflows/coverage-windows.yml + - codecov.yml concurrency: group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }} diff --git a/codecov.yml b/codecov.yml index 80ee32b360abce..3464efeeccfbd0 100644 --- a/codecov.yml +++ b/codecov.yml @@ -1,19 +1,20 @@ -# TODO(bcoe): re-enable coverage report comments, once we can figure out -# how to make them more accurate for the Node.js project, -# See: https://github.com/nodejs/node/issues/35759 -comment: false -# # Only show diff and files changed: -# layout: "diff, files" -# # Don't post if no changes in coverage: -# require_changes: true +comment: + # Only show diff and files changed: + layout: diff, files + # Don't post if no changes in coverage: + require_changes: true codecov: branch: main notify: # Wait for all coverage builds: - after_n_builds: 2 + # - coverage-linux.yml + # - coverage-windows.yml + # - coverage-linux-without-intl.yml + after_n_builds: 3 coverage: + # Useful for blocking Pull Requests that don't meet a particular coverage threshold. status: project: off patch: off