Skip to content
This repository has been archived by the owner on May 13, 2019. It is now read-only.

Revise Flaky Tests Wiki Page #13

Closed
Trott opened this issue Jan 27, 2016 · 2 comments
Closed

Revise Flaky Tests Wiki Page #13

Trott opened this issue Jan 27, 2016 · 2 comments

Comments

@Trott
Copy link
Member

Trott commented Jan 27, 2016

https://github.com/nodejs/node/wiki/Flaky-tests

@Trott Trott mentioned this issue Jan 28, 2016
@Trott
Copy link
Member Author

Trott commented Feb 22, 2016

Page mostly looks OK to me. Main issues:

  • Talks a lot about node-accept-pull-request but we haven't been using that for a long time and it's not clear that it will be coming back. (Personally, I'd love to see it come back, but not everyone seems on board with that.)
  • This segment probably needs some review/revision:

The issue should be marked with the P-1 label, and assigned to the next milestone for the branch in which the test is marked as flaky. You should also mention at-nodejs/collaborators in the issue.

Specifically:

  1. P-1 label doesn't seem to exist
  2. Milestones seem to only mark subsequent major versions right now (currently 6.0.0 and 7.0.0). If that's what we want, then great. But if not, then that needs to be revised, I guess.
  3. At-mentioning nodejs/collaborators. Will that create so much noise that it gets ignored? Or should we do that? Should it instruct people to at-mention nodejs-testing instead?

@Trott Trott mentioned this issue Feb 26, 2016
@Trott
Copy link
Member Author

Trott commented Dec 20, 2017

I've edited the wiki page to correct the identified issues.

@Trott Trott closed this as completed Dec 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant