init_wildduck_transaction in index, in case hook_mail not run #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no guarantee that hook_mail will get run. If some other Haraka plugin runs on hook_mail before wildduck and calls `next(OK)`, then wildduck's hook_mail won't ever get called. That crashes the plugin in the recipient handler that does this: `const { recipients, forwards, users } = txn.notes.targets;`.
Additionally:
- add @haraka/eslint-config (which brings in Haraka globals)
- use shorter logging syntax
-
andris9
requested changes
Apr 16, 2024
andris9
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no guarantee that hook_mail will get run. If some other Haraka plugin runs on hook_mail before wildduck and calls
next(OK), then wildduck's hook_mail won't ever get called. That crashes the wildduck plugin in the recipient handler that does this:const { recipients, forwards, users } = txn.notes.targets;Additional Changes:
punycode/), as it doesn't suffer from edge cases (see Naming collision when installing punycode via npm mathiasbynens/punycode.js#79, Suggest usingpunycode.jsnpm package mathiasbynens/punycode.js#122, Importing in node 21 mathiasbynens/punycode.js#132