Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The nargo test command should have a way to select exactly one test #2271

Closed
phated opened this issue Aug 10, 2023 · 0 comments · Fixed by #2272
Closed

The nargo test command should have a way to select exactly one test #2271

phated opened this issue Aug 10, 2023 · 0 comments · Fixed by #2272
Assignees
Labels
enhancement New feature or request

Comments

@phated
Copy link
Contributor

phated commented Aug 10, 2023

Problem

In #2017, the module path was prefixed to test names; however, if you run a test in the root package, such as test_main, it would run any test_main function in any submodule since their full file path contains test_main.

This could be considered a bug, but it requires a new feature. Cargo has the --exact flag which does full equality instead of a string match.

Happy Case

Add --exact flag and use equality check instead of .contains()

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

Yes

Support Needs

No response

@phated phated added the enhancement New feature or request label Aug 10, 2023
@phated phated self-assigned this Aug 10, 2023
@phated phated added this to Noir Aug 10, 2023
@phated phated moved this to 🏗 In progress in Noir Aug 10, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Noir Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant