Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move bounded_vec into the stdlib #4198

Closed
kevaundray opened this issue Jan 29, 2024 · 2 comments
Closed

Move bounded_vec into the stdlib #4198

kevaundray opened this issue Jan 29, 2024 · 2 comments
Assignees
@vezenovm
Labels
enhancement New feature or request

Comments

@kevaundray
Copy link
Contributor

kevaundray commented Jan 29, 2024 •
edited by vezenovm
Loading

Problem

With the removal of nested slices, the BoundedVec struct which essentially acts as a array where the max size/capacity is given, will become more useful.

Happy Case

Copy the BoundedVec implementation from https://github.com/AztecProtocol/aztec-packages/blob/1c8ea497fb1d64da64cb240917a60d57bd1efef8/yarn-project/noir-protocol-circuits/src/crates/types/src/utils/bounded_vec.nr#L1

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response
@kevaundray kevaundray added the enhancement New feature or request label Jan 29, 2024
@kevaundray kevaundray added this to Noir Jan 29, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jan 29, 2024
@kevaundray kevaundray mentioned this issue Jan 29, 2024
Merged
5 tasks
@vezenovm
Copy link
Contributor

This is a repeat of this issue (#4020)

@vezenovm
Copy link
Contributor

Closing in favor of the older issue

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vezenovm vezenovm

Labels
enhancement New feature or request
Projects
Noir
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevaundray @vezenovm