Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish between internal and external imports with :: prefix #4947

Closed
michaeljklein opened this issue Apr 30, 2024 · 1 comment
Closed
Labels
enhancement New feature or request

Comments

@michaeljklein
Copy link
Contributor

michaeljklein commented Apr 30, 2024

Problem

We can have a crate with a dependency foo but also a submodule foo. Rust disambiguates these with ::foo to select the dependency rather the submodule (or vice versa). We should have a test for this case in any case.

Happy Case

  • Add :: prefix to parser
  • Override case here to resolve externally when :: prefix is present
  • Test here

Project Impact

Nice-to-have

Impact Context

No response

Workaround

None

Workaround Description

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response

@michaeljklein michaeljklein added the enhancement New feature or request label Apr 30, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Apr 30, 2024
@TomAFrench
Copy link
Member

TomAFrench commented Dec 6, 2024

Removing dep isn't important imo

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants