Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor add_definition_location to take a Location #7177

Closed
asterite opened this issue Jan 24, 2025 · 0 comments · Fixed by #7185
Closed

chore: refactor add_definition_location to take a Location #7177

asterite opened this issue Jan 24, 2025 · 0 comments · Fixed by #7185

Comments

@asterite
Copy link
Collaborator

This method:

pub(crate) fn add_definition_location(

looks up the location of a definition to register it. It's a bit redundant since when we are defining something we know its location. Calling this before the definition location is known could lead to bugs like this: https://github.com/noir-lang/noir/pull/7174/files#r1928537789

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant