Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP formatter always uses the default configuration #7340

Closed
asterite opened this issue Feb 10, 2025 · 0 comments · Fixed by #7355
Closed

LSP formatter always uses the default configuration #7340

asterite opened this issue Feb 10, 2025 · 0 comments · Fixed by #7355
Labels
bug Something isn't working

Comments

@asterite
Copy link
Collaborator

Aim

If there's a noirfmt.toml file in a package or its workspace, that configuration should be picked up when a file is formatted via the LSP.

Expected Behavior

noirfmt.toml is picked up from the package the file is in or, if it doesn't exist, from the parent workspace.

Bug

The default formatter configuration is currently used, making it impossible to customize formatting while also using an IDE.

To Reproduce

Workaround

None

Workaround Description

No response

Additional Context

No response

Project Impact

None

Blocker Context

No response

Nargo Version

No response

NoirJS Version

No response

Proving Backend Tooling & Version

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response

@asterite asterite added the bug Something isn't working label Feb 10, 2025
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Feb 10, 2025
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant