You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Once #7333 is merged it would be nice if errors carried Locations instead of Spans. That way Elaborator::push_err would only need to take an error, not a file.
Then, some errors currently hold multiple spans, for example on duplicate errors (a duplication function) and that duplication could happen in different files so moving to Location instead of Span will also produce more correct error messages in some cases.
Additionally, let CustomDiagnostic API work with Location instead of Span, and make CustomLabel hold a Location instead of a Span and an optional FileId.
The text was updated successfully, but these errors were encountered:
Once #7333 is merged it would be nice if errors carried
Location
s instead ofSpan
s. That wayElaborator::push_err
would only need to take an error, not a file.Then, some errors currently hold multiple spans, for example on duplicate errors (a duplication function) and that duplication could happen in different files so moving to
Location
instead ofSpan
will also produce more correct error messages in some cases.Additionally, let
CustomDiagnostic
API work withLocation
instead ofSpan
, and makeCustomLabel
hold aLocation
instead of aSpan
and an optionalFileId
.The text was updated successfully, but these errors were encountered: