Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No duplicate error on impl function without self #7483

Closed
asterite opened this issue Feb 21, 2025 · 0 comments · Fixed by #7490
Closed

No duplicate error on impl function without self #7483

asterite opened this issue Feb 21, 2025 · 0 comments · Fixed by #7490
Assignees
Labels
bug Something isn't working

Comments

@asterite
Copy link
Collaborator

Aim

Given this code:

pub struct Foo {}

impl Foo {
    fn foo() {}
    fn foo() {}
}

fn main() {}

Expected Behavior

It should give an error saying that "foo" was already defined.

Bug

It doesn't give an error.

Note that if it's fn foo(self) then an error is produced, so this is exclusively to functions without a self.

To Reproduce

Workaround

None

Workaround Description

No response

Additional Context

No response

Project Impact

None

Blocker Context

No response

Nargo Version

No response

NoirJS Version

No response

Proving Backend Tooling & Version

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response

@asterite asterite added the bug Something isn't working label Feb 21, 2025
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Feb 21, 2025
@asterite asterite self-assigned this Feb 24, 2025
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant