fix(nargo): Switch order of writing acir file and acir checksum file #895
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Quick fix found while working on a separate project so no issue
Description
During
nargo compile
the checksum file is being written first followed by the acir file. We set an extension.acir.sha256
for the sha checksum. When we reset the extension we were mistakenly only resetting the last extension of.sha256
so the acir file being written totarget
was.acir.acir
.Summary of changes
We write the ACIR file followed by the checksum now. Running
nargo compile p
for example will now correctly givep.acir
andp.acir.sha256
.Dependency additions / changes
Test additions / changes
Checklist
cargo fmt
with default settings.Additional context